Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder StdioServerTransport shutdown procedure to avoid errors #7

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

chemicL
Copy link
Member

@chemicL chemicL commented Jan 28, 2025

In the tests occasionally the STDIO variant would fail due to dropped errors.

Motivation and Context

When exercising the StdioMcpSyncServerTests occasionally onErrorDropped signals would be logged signifying that the shutdown of the inbound is not properly ordered with regards to the outbound and the outbound-related Scheduler is shutdown before the pipeline has a chance to process the completion signal.

How Has This Been Tested?

./mvnw clean install

Breaking Changes

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

None

@chemicL chemicL added the bug Something isn't working label Jan 28, 2025
@tzolov tzolov merged commit c876609 into main Jan 28, 2025
@tzolov tzolov deleted the stdio-termination-reorder branch January 28, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants