Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): Fix StdioServerTransportProvider initialization flow #74

Merged
merged 1 commit into from
Mar 26, 2025
Merged

refactor(server): Fix StdioServerTransportProvider initialization flow #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions mcp/src/main/java/io/modelcontextprotocol/server/transport/StdioServerTransportProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ public StdioServerTransportProvider(ObjectMapper objectMapper, InputStream input
@Override
public void setSessionFactory(McpServerSession.Factory sessionFactory) {
// Create a single session for the stdio connection
this.session = sessionFactory.create(new StdioMcpSessionTransport());
var transport = new StdioMcpSessionTransport();
this.session = sessionFactory.create(transport);
transport.initProcessing();
}

@Override
Expand Down Expand Up @@ -142,10 +144,6 @@ public StdioMcpSessionTransport() {
"stdio-inbound");
this.outboundScheduler = Schedulers.fromExecutorService(Executors.newSingleThreadExecutor(),
"stdio-outbound");

handleIncomingMessages();
startInboundProcessing();
startOutboundProcessing();
}

@Override
Expand Down Expand Up @@ -181,6 +179,12 @@ public void close() {
logger.debug("Session transport closed");
}

private void initProcessing() {
handleIncomingMessages();
startInboundProcessing();
startOutboundProcessing();
}

private void handleIncomingMessages() {
this.inboundSink.asFlux().flatMap(message -> session.handle(message)).doOnTerminate(() -> {
// The outbound processing will dispose its scheduler upon completion
Expand Down