Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CompletableDeferred from weather-stdio-server sample #57

Merged
merged 4 commits into from
Mar 26, 2025
Merged

Remove CompletableDeferred from weather-stdio-server sample #57

merged 4 commits into from
Mar 26, 2025

Conversation

devcrocod
Copy link
Contributor

Motivation and Context

Fixed according to this comment

How Has This Been Tested?

Locally

Breaking Changes

No breaking changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@devcrocod devcrocod self-assigned this Mar 18, 2025
@devcrocod devcrocod changed the title Remove CompletableDeferred Remove CompletableDeferred from weather-stdio-server sample Mar 18, 2025
@devcrocod devcrocod assigned e5l and unassigned devcrocod Mar 19, 2025
@devcrocod devcrocod requested a review from e5l March 25, 2025 10:12
@e5l e5l enabled auto-merge (squash) March 26, 2025 08:25
@e5l e5l disabled auto-merge March 26, 2025 11:29
@e5l e5l enabled auto-merge (squash) March 26, 2025 11:29
@e5l e5l merged commit 68faa51 into main Mar 26, 2025
4 checks passed
@e5l e5l deleted the devcrocod/weather-stdio-server-patch0 branch March 26, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

@Mr3zee Mr3zee Mr3zee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devcrocod @e5l @Mr3zee