fix(fastmcp): handle strings containing numbers correctly #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sd2k . This is awesome. Can we rebase this on top of v1.2.x branch so that i can be a fix? |
This is a port of jlowin/fastmcp#63 to this repo - I guess the transition was made before this PR was merged into fastmcp, so it wasn't included here. See jlowin/fastmcp#62 for the initial bug report.
sd2k
force-pushed
the
handle-string-args-containing-numbers
branch
from
194b687 to
5abe811
Compare
|
@dsp-ant sure thing, I've changed the base to v1.2.x 👍 |
|
Hey @dsp-ant, sorry to bug but I think this is good to go and it's causing an issue in the Grafana MCP server where we have an integer param. Any chance we could merge this week? 🙏 thanks! |
dsp-ant
approved these changes
Jan 20, 2025
|
Sorry for the delay and thank you for the fix. |
sd2k
added a commit
to grafana/mcp-grafana
that referenced
this pull request
Jan 27, 2025
Contains a [bugfix] for tools with integer parameters. [bugfix]: modelcontextprotocol/python-sdk#142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of jlowin/fastmcp#63 to this repo - I guess the transition was made before this PR was merged into fastmcp, so it wasn't included here.
See jlowin/fastmcp#62 for the initial bug report.