feat: update types to 2024-11-05 schema #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jerome3o-anthropic
approved these changes
Jan 23, 2025
src/mcp/types.py
Outdated
| @@ -344,6 +343,12 @@ class ListResourcesRequest(PaginatedRequest): | |||
| params: RequestParams | None = None | |||
|
|
|||
|
|
|||
| class Annotations(BaseModel): | |||
| audience: list[Role] | None = None | |||
| priority: float | None = None | |||
There was a problem hiding this comment.
[nit/non-blocking] the spec list min/max values for this (https://github.com/modelcontextprotocol/specification/blob/363e36b3fabad8ec6253e468a74c8f7fc972e539/schema/2024-11-05/schema.json#L18)
We could add pydantic level validation for this
There was a problem hiding this comment.
Great point. Totally didnt remember that this was a thing. Thank you.
jerome3o-anthropic
previously approved these changes
Jan 23, 2025
dsp-ant
force-pushed
the
davidsp/types-2024-11-05
branch
from
50e60d7 to
bd74227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan