Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper generic for Context #245

Merged
merged 2 commits into from
Mar 11, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/mcp/server/fastmcp/server.py
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@
from mcp.server.session import ServerSession
from mcp.server.sse import SseServerTransport
from mcp.server.stdio import stdio_server
from mcp.shared.context import RequestContext
from mcp.shared.context import LifespanContextT, RequestContext
from mcp.types import (
AnyFunction,
EmbeddedResource,
@@ -564,7 +564,7 @@ def _convert_to_content(
return [TextContent(type="text", text=result)]


class Context(BaseModel):
class Context(BaseModel, Generic[LifespanContextT]):
"""Context object providing access to MCP capabilities.
This provides a cleaner interface to MCP's RequestContext functionality.
@@ -598,13 +598,13 @@ def my_tool(x: int, ctx: Context) -> str:
The context is optional - tools that don't need it can omit the parameter.
"""

_request_context: RequestContext[ServerSession, Any] | None
_request_context: RequestContext[ServerSession, LifespanContextT] | None
_fastmcp: FastMCP | None

def __init__(
self,
*,
request_context: RequestContext | None = None,
request_context: RequestContext[ServerSession, LifespanContextT] | None = None,
fastmcp: FastMCP | None = None,
**kwargs: Any,
):
@@ -620,7 +620,7 @@ def fastmcp(self) -> FastMCP:
return self._fastmcp

@property
def request_context(self) -> RequestContext:
def request_context(self) -> RequestContext[ServerSession, LifespanContextT]:
"""Access to the underlying request context."""
if self._request_context is None:
raise ValueError("Context is not available outside of a request")
8 changes: 5 additions & 3 deletions src/mcp/shared/context.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
from dataclasses import dataclass
from typing import Generic, TypeVar
from typing import Any, Generic

from typing_extensions import TypeVar

from mcp.shared.session import BaseSession
from mcp.types import RequestId, RequestParams

SessionT = TypeVar("SessionT", bound=BaseSession)
LifespanContextT = TypeVar("LifespanContextT")
SessionT = TypeVar("SessionT", bound=BaseSession[Any, Any, Any, Any, Any])
LifespanContextT = TypeVar("LifespanContextT", default=None)


@dataclass