Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable context injection into resources #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonvet
Copy link

@jonvet jonvet commented Mar 8, 2025

closes #244

Motivation and Context

According to the readme it should be possible to pass a Context to a resource (like it is for tools), but that's currently throwing an error (#244)

How Has This Been Tested?

Added tests, and confirmed with inspector that the below demo server works as intended:

from mcp.server.fastmcp import FastMCP, Context

mcp = FastMCP("Demo")


@mcp.resource("identification://{name}")
def get_ids(name: str, ctx: Context) -> str:
    request_id = ctx.request_id
    client_id = ctx.client_id
    return str(f"{request_id},{client_id}")

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

I tried to follow a similar structure to the way context is injected in tools

@fubuloubu
Copy link

I tested this and it works for me

@fubuloubu
Copy link

@dsp-ant any updates with this one? useful for me

@NetanelBollag
Copy link

Waiting for this to be fixed too 🫶

@fubuloubu
Copy link

@dsp-ant I rebased this PR here: #413

I have been testing with this fix and it works perfectly

@jonvet jonvet force-pushed the jonvet/resources-with-context branch 2 times, most recently from 2cc3e0e to 16a6ac0 Compare April 3, 2025 20:45
@jonvet jonvet force-pushed the jonvet/resources-with-context branch from 748ea91 to 488a6d6 Compare April 13, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@app.resource() does not accept ctx: Context
3 participants