Close unclosed resources in the whole project #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome3o-anthropic
previously approved these changes
Mar 12, 2025
src/mcp/shared/session.py
Outdated
| return result_type.model_validate(response_or_error.result) | ||
| finally: | ||
| await response_stream.aclose() | ||
| await response_stream_reader.aclose() |
There was a problem hiding this comment.
Seems like we'd also like to delete the entry in self._response_streams also
There was a problem hiding this comment.
optional - I can get this later if needed
|
Looks like there are a bunch of check failures. I'm not sure if these are even related though |
|
I think it's from a change that I made yesterday, but unrelated to this PR. I think it was merged before the pipeline run? 🤔 |
|
This leaves one pytest error which might be legit |
Kludex
commented
Mar 13, 2025
| @@ -67,6 +67,9 @@ packages = ["src/mcp"] | |||
| include = ["src/mcp", "tests"] | |||
| venvPath = "." | |||
| venv = ".venv" | |||
| strict = [ | |||
| "src/mcp/server/fastmcp/tools/base.py", | |||
There was a problem hiding this comment.
More should be added here.
Kludex
commented
Mar 13, 2025
Kludex
changed the title
send_request
dsp-ant
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be using this branch on PydanticAI. I can't add tests otherwise.