Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Linux configuration path in get_claude_config_path #270

Merged
merged 7 commits into from
Mar 13, 2025

Conversation

emsi
Copy link
Contributor

@emsi emsi commented Mar 12, 2025

Motivation and Context

There's a community version of Claude desktop at:
https://github.com/emsi/claude-desktop (originally forked from https://github.com/aaddrick/claude-desktop-debian).

Unfortunately current version of MCP SDK does not support Linux yet there is nothing in the docs that indicate that and the uv run mcp install server.py command exits with a message "Claude app not found", while it's not actually looking for Claude Desktop app on Linux at all.
This patch addresses that and enables the SDK to install MCP servers in Claude desktop app on Linux.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

dsp-ant
dsp-ant previously approved these changes Mar 12, 2025
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to accept this as it's a good 80/20 solution, but to be correct, we should probably correctly respect XDG env variables and fallback to home for linux.

@emsi
Copy link
Contributor Author

emsi commented Mar 12, 2025

Happy to accept this as it's a good 80/20 solution, but to be correct, we should probably correctly respect XDG env variables and fallback to home for linux.

This d73cf9b should honor XDG_CONFIG_HOME

dsp-ant
dsp-ant previously approved these changes Mar 13, 2025
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you

@dsp-ant
Copy link
Member

dsp-ant commented Mar 13, 2025

I added a fix for the line length myself.

@dsp-ant dsp-ant merged commit 5c9f688 into modelcontextprotocol:main Mar 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants