fix: enable HTTP redirect handling in SSE client #284
Conversation
Updated the httpx AsyncClient to explicitly set follow_redirects=True to handle redirect responses from remote MCP servers. This fixes an issue where connections to servers that return redirects (like yo-mcp.com) would fail. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
| @@ -43,7 +43,7 @@ async def sse_client( | |||
| async with anyio.create_task_group() as tg: | |||
| try: | |||
| logger.info(f"Connecting to SSE endpoint: {remove_request_params(url)}") | |||
| async with httpx.AsyncClient(headers=headers) as client: | |||
| async with httpx.AsyncClient(headers=headers, follow_redirects=True) as client: | |||
There was a problem hiding this comment.
We have multiple spots where we create an AsyncClient. We should introduce a function to create a stnadard AsyncClient with respective options.
|
I can’t really envision a scenario where you wouldn’t want to follow redirects since it’s a core part of the http protocol. I think adding options is YAGNI but if you think it’s necessary I can prompt claude to fix it. many pointers on what I should do to get this PR green? |
|
There are lint errors that should be fixed. My take is I don't think this PR should add more options. |
| @@ -43,7 +43,7 @@ async def sse_client( | |||
| async with anyio.create_task_group() as tg: | |||
| try: | |||
| logger.info(f"Connecting to SSE endpoint: {remove_request_params(url)}") | |||
| async with httpx.AsyncClient(headers=headers) as client: | |||
| async with httpx.AsyncClient(headers=headers, follow_redirects=True) as client: | |||
There was a problem hiding this comment.
We have multiple spots where we create an AsyncClient. We should introduce a function to create a stnadard AsyncClient with respective options.
|
I think we can pass the client, instead of using a factory. |
that works too, but we need to make sure we have a central creation point to not have to sync options across client object creations. |
Updated the httpx AsyncClient to explicitly set follow_redirects=True to handle redirect responses from remote MCP servers. This fixes an issue where connections to servers that return redirects (like yo-mcp.com) would fail.
Motivation and Context
When connecting to certain MCP servers (like yo-mcp.com) that respond with HTTP redirects, the client would fail to establish a connection. This is because the redirect wasn't being followed automatically by the SSE client. The TypeScript client handles this correctly, but the Python client needed an explicit configuration.
How Has This Been Tested?
scripts/test_redirect.py) that connects to https://yo-mcp.com/mcp/7NIUz0cvfStY6-wSsVyY3 and verifies the redirect handling works correctlyBreaking Changes
None. This is a non-breaking bug fix that enables better compatibility with remote servers.
Types of changes
Checklist
Additional context
The issue was simple - httpx has
follow_redirects=Trueby default, but for some reason the redirect wasn't being followed by the SSE client. Adding the explicit parameter resolves the issue. The test script shows how to connect to a remote MCP server and can be used as a reference for other developers.