-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show_server_info #296
base: main
Are you sure you want to change the base?
show_server_info #296
Conversation
@Kludex can you review ? |
@dsp-ant can you look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kludex any opinions? I personally understand why you would want this, but i think it would be better suited in your application as either a call before starting the server or as an extension to the FastMCP server class. I appreciate the effort but would politely decline adding this.
I think it's more useful in the stdio case. Since nothing happens when you start the application. But on the HTTP, it will be a bit noisy... If it's in debug level then I think it's fine. |
ok i will change to debug |
7b317cd
to
b6380bb
Compare
@Kludex @dsp-ant moved it to helper method and class, I think its very useful, for example in my code when im using sse i will add a route that return this object in some route for example /info (like in rest api have swagger json doc) |
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context