Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_server_info #296

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

barnuri
Copy link
Contributor

@barnuri barnuri commented Mar 16, 2025

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@barnuri barnuri requested a review from Kludex March 16, 2025 12:23
@barnuri
Copy link
Contributor Author

barnuri commented Mar 19, 2025

@Kludex can you review ?

@barnuri
Copy link
Contributor Author

barnuri commented Mar 27, 2025

@dsp-ant can you look ?

Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kludex any opinions? I personally understand why you would want this, but i think it would be better suited in your application as either a call before starting the server or as an extension to the FastMCP server class. I appreciate the effort but would politely decline adding this.

@Kludex
Copy link
Member

Kludex commented Mar 28, 2025

I think it's more useful in the stdio case. Since nothing happens when you start the application.

But on the HTTP, it will be a bit noisy...

If it's in debug level then I think it's fine.

@barnuri
Copy link
Contributor Author

barnuri commented Mar 28, 2025

ok i will change to debug

@barnuri barnuri requested a review from dsp-ant March 28, 2025 05:57
@barnuri
Copy link
Contributor Author

barnuri commented Mar 28, 2025

@Kludex @dsp-ant moved it to helper method and class, I think its very useful, for example in my code when im using sse i will add a route that return this object in some route for example /info (like in rest api have swagger json doc)
the idea of it is to have something simple without creating a client that can be easily visible
same for using stdio and then i will use the debug log
i hope you would like it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants