Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove StdioServerParameters class #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

QuantGeekDev
Copy link

client/stdio and client/sse use two different patterns for initialization, this PR tries to standardize it after discussions with @Kludex by removing StdioServerParameters

Motivation and Context

Continuation to the discussion here: #300

How Has This Been Tested?

Testing with Claude Desktop's config

Breaking Changes

This is a breaking change to how Stdio is initialized, it is no longer done via StdioServerParameters

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@Kludex
Copy link
Member

Kludex commented Mar 17, 2025

I don't think we want to add breaking changes, so we'd support both, and add a deprecation warning when using settings parameter.

@QuantGeekDev
Copy link
Author

I don't think we want to add breaking changes, so we'd support both, and add a deprecation warning when using settings parameter.

Got it, that makes sense. I'll add implementation and test cases for this

@QuantGeekDev
Copy link
Author

@Kludex Do you think it makes sense to add this, or are we going to see an overhaul here with the changes from the new spec? I can get this in over the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants