Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback for logging message notification to client #314

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented Mar 18, 2025

Similar to sampling_callback, adding an ability to pass logging_callback to the client session.

Motivation and Context

There is no easy way to process Logging notifications on the client.

How Has This Been Tested?

Unit tests

Breaking Changes

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Alternatively, a single server notifications callback can be added to the client, instead of specialised callback like logging and progress notification.

Sorry, something went wrong.

@dsp-ant dsp-ant self-requested a review March 19, 2025 09:38
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dsp-ant dsp-ant merged commit 08f4e01 into modelcontextprotocol:main Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants