Add strict mode to pyright #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp-ant
force-pushed
the
add-strict-mode-pyright
branch
from
30149e3 to
96377b0
Compare
|
I have a fix locally, I need to push it. |
…ocol/python-sdk into add-strict-mode-pyright
Kludex
commented
Mar 20, 2025
| @@ -16,33 +16,36 @@ | |||
| <!-- omit in toc --> | |||
| ## Table of Contents | |||
|
|
|||
| - [Overview](#overview) | |||
There was a problem hiding this comment.
My IDE "fixes" this... It has been like this for years and I never bothered to fix it... If it's not important, I'd appreciate it if we just ignore this.
dsp-ant
approved these changes
Mar 20, 2025
| @@ -80,7 +80,7 @@ def pre_parse_json(self, data: dict[str, Any]) -> dict[str, Any]: | |||
| dicts (JSON objects) as JSON strings, which can be pre-parsed here. | |||
| """ | |||
| new_data = data.copy() # Shallow copy | |||
| for field_name, field_info in self.arg_model.model_fields.items(): | |||
| for field_name, _field_info in self.arg_model.model_fields.items(): | |||
There was a problem hiding this comment.
sounds like we can make this
Suggested change
| for field_name, _field_info in self.arg_model.model_fields.items(): | |
| for field_name in self.arg_model.model_fields.keys(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are conceptually wrong types in
mcp/types.pythat I can't solve easily.