Use default environment even when env
is provided
#327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #326 - MCP client with npx not working when env parameter of StdioServerParameters is set
Motivation and Context
See issue #326
Discarding the output of
get_default_environment()
when server.env has additional variables doesn't make sense. A reasonable assumption is that settingenv
variables adds to what was there otherwise.How Has This Been Tested?
I tested it and it fixed the issue for me.
Breaking Changes
If somebody relied on setting the
env
parameter to clear default environment variables then they would need to change their code.Types of changes
Checklist
Additional context
None