refactor: Make types.py strictly typechecked. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now making the types module typecheck in strict mode. This is mostly achieved by passing the correct types to the generic type variables. We ran into one specific issue with `JSONRPCRequest` and `JSONRPCNotification`. Both are generic classes that take a `dict[str, Any]` as params and just a plain string as method. However, since the TypeVar for `RequestT` and `NotificationT` are bound to `RequestParams` and `NotificationParams` respectively we get into a type issue. There are two ways of solving this: 1. Widen the bound by allowing explicitly for `dict[str, Any]` 2. Make JSONRPCRequest and JSONRPCNotificaiton not part of the type hierarchy with Request and Notification roots. It felt most naturally to keep JSONRPCRequest/JSONRPCNotification part of the type hierarchy and allow for general passing of dict[str, Any]. This now typechecks.
dsp-ant
requested review from
jerome3o-anthropic,
jspahrsummers and
Kludex
and removed request for
jerome3o-anthropic
Kludex
reviewed
Mar 20, 2025
Comment on lines
+67
to
+70
| RequestParamsT = TypeVar("RequestParamsT", bound=RequestParams | dict[str, Any] | None) | ||
| NotificationParamsT = TypeVar( | ||
| "NotificationParamsT", bound=NotificationParams | dict[str, Any] | None | ||
| ) |
There was a problem hiding this comment.
This is a bit weird tho... I'd like to spend some minutes checking if we can be a bit stricter here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now making the types module typecheck in strict mode.
This is mostly achieved by passing the correct types to the
generic type variables.
We ran into one specific issue with
JSONRPCRequestandJSONRPCNotification. Both are generic classes that take adict[str, Any]as params and just a plain string as method.However, since the TypeVar for
RequestTandNotificationTarebound to
RequestParamsandNotificationParamsrespectivelywe get into a type issue.
There are two ways of solving this:
dict[str, Any]type hierarchy with Request and Notification roots.
It felt most naturally to keep JSONRPCRequest/JSONRPCNotification
part of the type hierarchy and allow for general passing of
dict[str, Any].
This now typechecks.