Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/base64 handling (Issue #342) #343

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

evalstate
Copy link
Contributor

Single line change to lowlevel/server.py + test to verify that Base64 decoding is not url safe and as expected by the Client.

Motivation and Context

Transmitting Binary resources.

How Has This Been Tested?

Tested, screenshots in issue #342

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@dsp-ant dsp-ant self-requested a review March 27, 2025 09:17
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you!

@dsp-ant dsp-ant merged commit 6d66ab8 into modelcontextprotocol:main Mar 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants