Skip to content

Fix Type Errors in Sample Code #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Type Errors in Sample Code #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ from dataclasses import dataclass
from fake_database import Database # Replace with your actual DB type

from mcp.server.fastmcp import Context, FastMCP
from mcp.server.session import ServerSessionT

# Create a named server
mcp = FastMCP("My App")
Expand Down Expand Up @@ -192,7 +193,7 @@ mcp = FastMCP("My App", lifespan=app_lifespan)

# Access type-safe lifespan context in tools
@mcp.tool()
def query_db(ctx: Context) -> str:
def query_db(ctx: Context[ServerSessionT, AppContext]) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run this locally? I don't think this works properly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the Pyright / mypy errors but doesn't actually work. I’ve opened issue #357 and am currently preparing a PR to fix it.

"""Tool that uses initialized resources"""
db = ctx.request_context.lifespan_context.db
return db.query()
Expand Down
Loading