Skip to content

Fixes incorrect casting into int for numbers in string format #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

kafkasl
Copy link
Contributor

@kafkasl kafkasl commented Mar 27, 2025

Fixes #316

When a parameter in fastMCP is a number, but the type of the tool is string, it is regardless casted into int, and thus the tool fails. This issue was solved in the original FastMCP repo but apparently it was lost. I just added the code back as suggested together with its test.

Original fix

Current Issue report:

Motivation and Context

Fixes tool input numbers being cast into int when they are specified as str.

How Has This Been Tested?

I added back the original test. It matches the errors I'm seeing when using FastMCP 1.5.0 in my project.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The fix seems to have gotten lost in translation to the official SDK.

@dsp-ant dsp-ant merged commit ec62372 into modelcontextprotocol:v1.3.x Mar 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants