Skip to content

Support custom client info throughout client APIs #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jerome3o-anthropic
Copy link
Contributor

Summary

  • Allow custom client info to be specified throughout the client API surface
  • Add comprehensive tests to verify both default and custom client info behavior

Test plan

  • Run client session tests which verify custom and default client info scenarios
  • Ensure all existing tests still pass

🤖 Generated with Claude Code

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good


received_client_info = None

async def mock_server():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth extracting the mock server into a shared fixture and parameterizing the client info test cases?

@jerome3o-anthropic jerome3o-anthropic merged commit c4beb3e into main Apr 10, 2025
8 checks passed
@jerome3o-anthropic jerome3o-anthropic deleted the jerome/feature/allow-client-info-specification-in-client branch April 10, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants