Skip to content

normalize string ID to int in server messages for compatibility #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/mcp/client/sse.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,19 @@ async def sse_reader(
message = types.JSONRPCMessage.model_validate_json( # noqa: E501
sse.data
)

# Extract the message ID safely from the root object
msg_id = getattr(getattr(message, "root", None), "id", None)

# Normalize ID to integer if it's a numeric string
# Some non-standard SSE servers may return numeric IDs as strings,
# even if the original request used an integer ID.
if isinstance(msg_id, str) and msg_id.isdigit():
message.root.id = int(msg_id)
elif not isinstance(msg_id, int):
logger.warning(f"Ignored message with invalid ID: {msg_id!r}")
continue

logger.debug(
f"Received server message: {message}"
)
Expand Down
Loading