Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Devcontainer for Development Environment #81

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

Z9RTM
Copy link
Contributor

@Z9RTM Z9RTM commented Apr 1, 2025

Motivation and Context

Issue #80

How Has This Been Tested?

Simply executing the cargo build command is not sufficient. To build a wasi example project, must use cargo build -p wasi --target wasm32-wasip2

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@jokemanfire
Copy link
Collaborator

Could you add a brief document describe the use of dev-container in readme? pls

Comment on lines +192 to +194
## Development with Dev Container

See [docs/DEVCONTAINER.md](docs/DEVCONTAINER.md) for instructions on using Dev Container for development.
Copy link
Contributor Author

@Z9RTM Z9RTM Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jokemanfire, I've created a dedicated document for Dev Container setup in docs/DEVCONTAINER.md as we discussed. I've also added a link to it in the README.md. Could you please take a look and let me know if you have any feedback?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thks , and pls add a link in root's readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback.
The link to the Dev Container documentation has already been added to the project root's README.md, under the "Development with Dev Container" section.

Please take a look at it here: https://github.com/Z9RTM/rust-sdk/tree/devcontainer?tab=readme-ov-file#development-with-dev-container

If you still can't find it or have any further questions, please let me know.

@jokemanfire
Copy link
Collaborator

#58

@jokemanfire
Copy link
Collaborator

Thanks!

@jokemanfire jokemanfire merged commit d5c4bf0 into modelcontextprotocol:main Apr 2, 2025
6 checks passed
@Z9RTM Z9RTM deleted the devcontainer branch April 2, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants