Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sampling #500

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix sampling #500

merged 1 commit into from
Jan 8, 2025

Conversation

SecretiveShell
Copy link
Contributor

fix sampling so that text is returned not [object Object]

Description

Server Details

  • Server: everythinh
  • Changes to: sample llm tool

Motivation and Context

unblocks sampling pr in python-sdk

How Has This Been Tested?

I tested this locally with my sampling client demo

Breaking Changes

if you depend on the bug then its breaking otherwise no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

for modelcontextprotocol/python-sdk#132

Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dsp-ant dsp-ant merged commit 538a6a3 into modelcontextprotocol:main Jan 8, 2025
23 checks passed
laith-abood pushed a commit to laith-abood/mcp-claude that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants