Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md new SSE Server to match defaults in inspector #140

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented Jan 26, 2025

When launching inspector and changing to use SSE, the URL is set to http://localhost:3001/sse. It's quite confusing to have an example use different endpoint names and port, hence the change.

Motivation and Context

When following readme for creating sse server it became quite confusing which endpoint should be implemented.

How Has This Been Tested?

Checked in the preview

Breaking Changes

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed
image

When launching inspector and changing to use SSE, the URL is set to `http://localhost:3001/sse`. It's quite confusing to have an example use different endpoint names and port, hence the change.
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jspahrsummers jspahrsummers merged commit a2b7afd into modelcontextprotocol:main Jan 27, 2025
MediaInfluences pushed a commit to MediaInfluences/typescript-sdk that referenced this pull request Apr 3, 2025
Update README.md new SSE Server to match defaults in inspector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants