Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cwd to StdioServerParameters #146

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented Feb 10, 2025

Add a cwd option to StdioServerParameters

Motivation and Context

Some MCP authors have asked us to be able to set the current working directory of the process so that they can know where to find certain files.

How Has This Been Tested?

I've tested manually, but given the quantity of tests this felt like it would have been a bit niche and slightly trivial. Happy to add a test though if it feels important

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/A

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense!

@jspahrsummers jspahrsummers merged commit 2500b9c into modelcontextprotocol:main Feb 11, 2025
2 checks passed
@sestinj
Copy link
Contributor Author

sestinj commented Feb 11, 2025

Thanks for the quick merge @jspahrsummers! Do you have an idea of when the next release is likely to be? I have a few users that are excited to see this working and just want to be able to communicate with them about timing

@jspahrsummers
Copy link
Member

Just released 1.5.0 with this PR in there 🙏

@sestinj
Copy link
Contributor Author

sestinj commented Feb 12, 2025

Sweet! Thank you again

MediaInfluences pushed a commit to MediaInfluences/typescript-sdk that referenced this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants