Misc fixes in auth #157
Merged
Misc fixes in auth #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
k6l3
approved these changes
Feb 24, 2025
src/client/auth.ts
Outdated
| try { | ||
| response = await fetch(url); | ||
| } catch { | ||
| return undefined; |
There was a problem hiding this comment.
Sure you don't want to log/throw the exception?
jspahrsummers
approved these changes
Feb 24, 2025
src/server/auth/handlers/register.ts
Outdated
Comment on lines
92
to
96
| client_secret_expires_at: isPublicClient | ||
| ? clientSecretExpirySeconds > 0 | ||
| ? clientIdIssuedAt + clientSecretExpirySeconds | ||
| : 0 | ||
| : undefined, |
There was a problem hiding this comment.
Nested ternaries is a bit much—can we pull some of this out into one or two intermediate variables?
src/client/auth.ts
Outdated
| } | ||
| }); | ||
| } catch { | ||
| try { |
There was a problem hiding this comment.
Do we want to conditionalize this based on what the error actually was?
src/client/auth.ts
Outdated
Comment on lines
174
to
177
| try { | ||
| response = await fetch(url); | ||
| } catch { | ||
| return undefined; |
There was a problem hiding this comment.
I think it should be fine to let this error propagate if there's an actual network error (or otherwise), rather than a 404.
jerome3o-anthropic
deleted the
jerome/fix/no-mcp-header-in-metadata-fetching
branch
MediaInfluences
pushed a commit
to MediaInfluences/typescript-sdk
that referenced
this pull request
Apr 3, 2025
…/jerome/fix/no-mcp-header-in-metadata-fetching * Check token expiry in requireAuth middleware * Gracefully handle cors issues in metadata fetching (experienced due to MCP-Protocol-Version header) * Don't set client secret expiry for public clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While hacking with this I ran into a few little issues, these are the fixes.