Add sessionID to RequestHandlerExtra type for tool invocations so multi-user services can distinguish users #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspahrsummers
approved these changes
Feb 24, 2025
| @@ -41,4 +41,6 @@ export interface Transport { | |||
| * Callback for when a message (request or response) is received over the connection. | |||
| */ | |||
| onmessage?: (message: JSONRPCMessage) => void; | |||
|
|
|||
| sessionId?: string; | |||
There was a problem hiding this comment.
Can you please add a docstring here?
There was a problem hiding this comment.
You bet, I'll take a look this afternoon
There was a problem hiding this comment.
Hey sir - added a test and a doc string, let me know if you need anything else!
9 tasks
|
👍 for this, we also got into the same problem with the same fix |
|
Very sorry, we've been underwater recently. Looks good—thank you! |
1 task
MediaInfluences
pushed a commit
to MediaInfluences/typescript-sdk
that referenced
this pull request
Apr 3, 2025
…id-to-context Add sessionID to RequestHandlerExtra type for tool invocations so multi-user services can distinguish users
MediaInfluences
pushed a commit
to MediaInfluences/typescript-sdk
that referenced
this pull request
Apr 3, 2025
…id-to-context Add sessionID to RequestHandlerExtra type for tool invocations so multi-user services can distinguish users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a sessionID field to the RequestHandlerExtra data that gets passed to tool callbacks, and wired it through from the transport session ID. Exposed the sessionID field on the abstract Transport interface.
Motivation and Context
This allows multi-user SSE-based MCP servers distinguish which user is invoking the tool based on their session ID (which in turn can be mapped to any data derived from the authentication token passed in HTTP headers).
Without this change, tool callbacks being served over SSE can't tell which user is making the request.
How Has This Been Tested?
Made a test service and tested it with Inspector. The tool callback was able to resolve the user ID associated with the requester's API key by using a map from session ID to user ID.
Breaking Changes
No.
Types of changes
Checklist
Additional context
N/A