Skip to content

Improve SSE endpoint sessionId parameter handling #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
Merged

Improve SSE endpoint sessionId parameter handling #177

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dad9eaf
Improve SSE endpoint sessionId parameter handling
akazwz Mar 9, 2025
389088e
Improve URL parameter handling in SSE using URL/URLSearchParams APIs
akazwz Apr 8, 2025
84447c2
Add tests for SSE server transport endpoint handling
akazwz Apr 9, 2025
976ff74
Replace type casting with direct sessionId property access in SSE tests
akazwz Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/server/sse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Transport } from "../shared/transport.js";
import { JSONRPCMessage, JSONRPCMessageSchema } from "../types.js";
import getRawBody from "raw-body";
import contentType from "content-type";
import { URL } from 'url';

const MAXIMUM_MESSAGE_SIZE = "4mb";

Expand Down Expand Up @@ -49,8 +50,17 @@ export class SSEServerTransport implements Transport {
});

// Send the endpoint event
// Use a dummy base URL because this._endpoint is relative.
// This allows using URL/URLSearchParams for robust parameter handling.
const dummyBase = 'http://localhost'; // Any valid base works
const endpointUrl = new URL(this._endpoint, dummyBase);
endpointUrl.searchParams.set('sessionId', this._sessionId);

// Reconstruct the relative URL string (pathname + search + hash)
const relativeUrlWithSession = endpointUrl.pathname + endpointUrl.search + endpointUrl.hash;

this.res.write(
`event: endpoint\ndata: ${encodeURI(this._endpoint)}?sessionId=${this._sessionId}\n\n`,
`event: endpoint\ndata: ${relativeUrlWithSession}\n\n`,
);

this._sseResponse = this.res;
Expand Down