console.error pollution logs removed in tests #194
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.error
mocked in tests (only locally where it's needed) to keep logs clearMotivation and Context
In current state when tests run there are several
console.error
prints which are signs of normal behaviour, but add additional noise and require careful checks ("green -- good" approach is not applicable). Mockingconsole.error
allows to keep logs clear (and if logs are clear ANY new information is visible, can't be lost in other logs and chances that it would be treated properly are higher.There is possibility to mock
console.error
globally (in jest.config.js), but IMO it could be potentially harmful (hides all error by default).How Has This Been Tested?
Tests themselves are fixed.
Breaking Changes
No
Types of changes
Checklist
Additional context
before:

after:
