Skip to content

✨ (client/index.ts): add optional RequestOptions parameter to connect… #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025

Conversation

nanbingxyz
Copy link
Contributor

An optional RequestOptions parameter (options) has been added to the client's connect method for timeout configuration.

Motivation and Context

The client often times out during initialization, so we need to adjust the timeout setting for the initialization reques

How Has This Been Tested?

Yes, the timeout parameter was validated by installing tools like mcp-browser-use that require lengthy dependency installations.

Breaking Changes

No, the options parameter is optional.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Sorry, something went wrong.

… method to allow additional configuration options

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@nanbingxyz
Copy link
Contributor Author

Could someone please review this? I’ve been stuck on the initialization timeout issue.Thanks!

@marcos-muino-garcia
Copy link

🆙 We have the same issue, and this PR would fix it

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jspahrsummers jspahrsummers merged commit 58adcd4 into modelcontextprotocol:main Apr 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants