fix: Environment variable merging in StdioClientTransport #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix environment variable handling in StdioClientTransport by properly merging default and custom environments.
Motivation and Context
Currently when providing custom environment variables, the code uses the nullish coalescing operator (
??
) which either uses custom environment OR default environment, not both. This fix ensures default environment variables are always included while still allowing custom variables to override them.How Has This Been Tested?
Updated the existing environment variable test and added a new test specifically for checking environment variable merging. All tests pass locally.
Breaking Changes
None. This is a bugfix that maintains the existing API.
Types of changes
Checklist
Additional context
This PR addresses issue #216.