StreamableHTTPClientTransport cleanup / fixes #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* always send headers specified in requestInit option * avoid doubled onerror call * use for-await to iterate SSE stream * remove outdated comments * simplify requestId tracking * throw error when response Content-Type is out of spec
beaulac
force-pushed
the
streamable-http-client-fixes
branch
from
5b9de6a to
a76004c
Compare
ihrpr
merged commit 77352db
into
modelcontextprotocol:ihrpr/response-returns-json
2 checks passed
Pizzaface
pushed a commit
to RewstApp/mcp-inspector
that referenced
this pull request
May 2, 2025
…ol-error-is-not-highlighted-for-sample-llm-tool-call-rejection fix: missing condition for lengthy strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
suggests changes for #299 ( cc @ihrpr )
Simplifies and fixes some inconsistencies in
StreamableHTTPClientTransport.How Has This Been Tested?
Existing StreamableHTTPClientTransport tests pass, two new tests added:
Breaking Changes
None
Types of changes
Checklist
Additional context