Refactor StreamableHttp Server tests #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihrpr
changed the title
jerome3o-anthropic
approved these changes
Apr 14, 2025
| }); | ||
| expect(response.status).toBe(400); | ||
| const errorData = await response.json(); | ||
| expectErrorResponse(errorData, -32600, /Only one initialization request is allowed/); |
There was a problem hiding this comment.
[non blocking q] even if it's a single message?
There was a problem hiding this comment.
An initialization request is not allowed to be batched with anything else, so we should enforce that there's only one message if initializing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's becoming very complex to add more tests to the StreamableHttp Server, hence refactoring.
Note to the reviewer: it's probably easier to look at a new tests and not try to compare, as most of the things changed