Skip to content

add custom headers on initial _startOrAuth call #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anthonjn
Copy link

@anthonjn anthonjn commented Apr 12, 2025

Ensure that custom headers provided in this._requestInit?.headers are included in the initial call to the /sse endpoint.

Motivation and Context

Fixes #317, where custom headers (e.g. Host, X-*) were not sent in the initial /sse request, but were correctly sent in /messages. This is needed for MCP servers behind proxies that rely on these headers.

This PR aligns the behavior of the /sse request with send() by ensuring that all custom headers (when provided) are forwarded appropriately.

How Has This Been Tested?

  • Added a test case to verify that custom headers, when specified, are included in the initial /sse request.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSEClientTransport's custom header support seems inconsistent
1 participant