-
Notifications
You must be signed in to change notification settings - Fork 593
Capability notification for the MCP Server #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
m-paternostro
wants to merge
4
commits into
modelcontextprotocol:main
Choose a base branch
from
m-paternostro:mp/notifier
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,698
−61
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to be logging this to the console. The spec says:
Should be something like:
That means your client is responsible for logging it to a file if needed. There is the mcp-proxy which has a
tapTransport
functionality that you could possibly use to siphon off these messages.Another consideration is respecting logging level. If the client sets the logging level on the server, and that level precludes sending 'debug' messages, then these messages should not be sent.
I'd like @jspahrsummers and/or @dsp-ant to weigh in on what the right way for this to be implemented is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I’m happy to revise the implementation as needed.
Just to clarify the intent a bit: the notification mechanism added here is independent of the MCP protocol or the client. It’s a lightweight, internal server-side feature intended for developers with access to the McpServer instance - for example, to hook into capability usage for debugging, monitoring, or performance analysis.
In the example, I went with
console.log
simply to keep things simple and non-prescriptive - the goal was to show that developers can observe these events, not to suggest they should forward them as MCP messages. That said, I’m happy to change how those messages are surfaced if the current approach is problematic.Since the logs are essential to demonstrating the feature in action, it would be good to preserve some form of visible output. Would it make sense to redirect them to
console.error
, or would you prefer a different logging mechanism entirely? Btw, I can use the opportunity to also change the current references toconsole.log
insimpleStreamableHttp.ts
.