Skip to content

Update README.md to use correct location of InMemoryEventStore #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025

Conversation

RamAnanth
Copy link
Contributor

Modified the README.md file to use the correct location of inMemoryEventStore to address #365

Motivation and Context

This change solves an issue with running the current example streamable HTTP servers provided in the README file leading to correct usage of the provided examples

How Has This Been Tested?

Breaking Changes

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • [ x] Documentation update

Checklist

  • [ x] I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • [ x] I have added or updated documentation as needed

Additional context

@2noScript
Copy link

It is located in the examples directory; is that correct?

@ihrpr
Copy link
Contributor

ihrpr commented Apr 19, 2025

I'd rather remove it entirely, in memory store is just for testing, it should not be used in production, as it really depends on how the server is deployed.

@RamAnanth
Copy link
Contributor Author

That makes sense, I will remove the usage of in memory event store completely from both the examples in the README file

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ihrpr ihrpr merged commit ac939a5 into modelcontextprotocol:main Apr 21, 2025
2 of 4 checks passed
@simonedstrom96
Copy link
Contributor

The line

    const eventStore = new InMemoryEventStore();

still persists in the readme, leading to confusion

Pizzaface pushed a commit to RewstApp/mcp-inspector that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants