Skip to content

Fixed Streamable HTTP Example #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

ferrants
Copy link
Contributor

@ferrants ferrants commented Apr 21, 2025

I tried copying the Streamable HTTP example and it didn't work until I updated these imports.

Motivation and Context

If someone wants to get going with the streaming http server code right away, they'll get errors and need to do the same as me.

How Has This Been Tested?

copied the sample code, made these changes, built the mcp server, got no errors. connected to inspector, appears to be working. it wasn't building before. inspector needed to be running off of main, not the released version, because the released version doesn't yet support the streamable-http server

Screenshot from 2025-04-21 00-03-13

Breaking Changes

None!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Not comprehensive, not sure where else this issue exists.

I tried copying the Streamable HTTP example and it didn't work until I updated these imports.
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ihrpr ihrpr merged commit 9d335f0 into modelcontextprotocol:main Apr 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants