fix: preserve subpaths in SSE endpoint URL construction #500
+328
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When MCP Server is deployed under a subpath URL (e.g.,
http://domain.com/subpath/sse
), clients fail to connect because of the way the SSE transport constructs URLs. Specifically, the use ofnew URL()
incorrectly discards the subpath, transforming requests intended for/messages/
intohttp://domain.com/messages/
, rather than preserving the correct subpath (http://domain.com/subpath/messages/
).This fix ensures that when a server is deployed at a non-root path, clients can still connect successfully by preserving the subpath in all URL communications.
How Has This Been Tested?
Breaking Changes
None. This is a pure bug fix that maintains backward compatibility. Existing deployments at root paths continue to work as before.
Types of changes
Checklist
Additional context
The fix involves two main changes:
The fix handles edge cases including empty paths, invalid URLs, and absolute URLs with proper error handling.
fixes #470