Support for linking plain message. #2937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourjr
requested changes
Jan 23, 2021
There was a problem hiding this comment.
This PR addresses multiple issues at once:
- Linking to plain messages
- The ability for different mods to edit another mods' message.
Each PR should only address one issue. The ability for different mods to edit messages is an intended feature.
If intended features are to be disabled, config options should be added.
|
Ok, sorry for that. Thanks for letting me know 👍. I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for linking plain message, regarding issue #2876.
As I tested it, delete and edit both worked.
Please check it. Any feedback would be appreciated.
Update:
-Added couple more commits.
And also please let me know if I used wrong methods or if there's anything needed change.