refactor(ui): rewrite file input component #3355
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrite file input component in TS + composition API - Remove unused props - Remove frontend duplicate component - Move the emit into an async callback - Add a spinner in the wide display mode while the callback is uploading - You should be able to see this in the markdown editor - Add a red border and error in wide display mode - Should be easily testable in the markdown editor - fmt (webstorm being annoying?)
|
Unfortunately, this PR has conflicts now. Apologies I did not have time to review it sooner |
|
I've been debating what to do with this PR. I hadn't figured out the formatting properly when I made the PR, so the diff is pretty bloated with unrelated formatting changes. Considering the amount of files with confilicts, I've decided to put this on the shelf for now. I still think the changes I made are good, but I'm not motivated to pour time into this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.