chore: Update css-loader/style-loader to fix esModule compat issue with assets loaded through file-loader #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by @mmarcon in compass-schema plugin in the latest beta, see this thread for context
Seems like the root cause was the file-loader update that started returning files as es modules with default export and css/style-loader not handling this correctly and rendering
[object Module]instead of a string when applying styles to the document. This PR bumps both loaders in all packages to latest version that works with our Node.js/Webpack version combo.Evergreen patch link (although evergreen will not catch the issue if it's still there)
Here's a screenshot of running compass-schema locally: