Skip to content

chore: prepare for non-prerelease #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

chore: prepare for non-prerelease #36

merged 1 commit into from
Jul 16, 2024

Conversation

nbbeeken
Copy link
Collaborator

Description

What is changing?

  • Remove releasing from pull_request workflow
  • Remove prerelease from config, do not tag npm package with alpha
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Proper release incoming 🚀

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from baileympearson July 15, 2024 19:17
@nbbeeken
Copy link
Collaborator Author

@baileympearson I'm not groking where release-6.1 obtains the artifacts that are uploaded by build.yml from, is there something more than just removing the old part of signing and uploading that is needed?

@nbbeeken
Copy link
Collaborator Author

From slack:

https://github.com/mongodb-labs/drivers-github-tools/blob/main/node/sign_node_package/action.yml

The download step happens inside our shared action

@baileympearson baileympearson merged commit c4df623 into main Jul 16, 2024
10 checks passed
@baileympearson baileympearson deleted the fix-ci-event branch July 16, 2024 19:02
baileympearson pushed a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants