chore(NODE-6656): update dev dependencies #64
Conversation
baileympearson
force-pushed
the
misc-dependencies
branch
from
b830056 to
b8aa3e8
Compare
baileympearson
changed the title
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@types/bindings": "^1.5.5", | ||
| "@types/chai": "^4.3.17", | ||
| "@types/mocha": "^10.0.9", | ||
| "@types/chai": "^5.0.1", |
There was a problem hiding this comment.
We should keep this in sync with our chai version (at least on the same major) right?
There was a problem hiding this comment.
Aren't the types going to be inaccurate? I assume this version corresponds to chai: 5 but we're still on chai: 4 here
There was a problem hiding this comment.
I thought types' major versions don't correlate to the actual version of the package. Is that incorrect?
There was a problem hiding this comment.
I think that's the only part (the major) of the type version that does, at least for the node types, the patch version doesn't correlate because at some point you make a type fix that bumps you past the corresponding release
There was a problem hiding this comment.
Okay, reverted.
nbbeeken
added
the
Primary Review
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@types/bindings": "^1.5.5", | ||
| "@types/chai": "^4.3.17", | ||
| "@types/mocha": "^10.0.9", | ||
| "@types/chai": "^5.0.1", |
There was a problem hiding this comment.
I think that's the only part (the major) of the type version that does, at least for the node types, the patch version doesn't correlate because at some point you make a type fix that bumps you past the corresponding release
baileympearson
force-pushed
the
misc-dependencies
branch
from
b8aa3e8 to
46f7995
Compare
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript