Skip to content

DRIVERS-555 Add a single-node replset config file #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

divjotarora
Copy link
Contributor

For DRIVERS-555, we will allow drivers to run the new tests in a separate task against a single-node replica set rather than running them in existing tasks. This is because the tests are timing based and we'd like to reduce the number of variables that could potentially introduce flaky failures (e.g. cumulative load on the server, number of nodes in the cluster, etc). This PR introduces a new config file that can be used by individual drivers to create this cluster.

Copy link
Contributor

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShaneHarvey
Copy link
Contributor

Should we also add an ssl+auth variant? Timeouts on TLS connections may work differently depending on the language.

@divjotarora
Copy link
Contributor Author

@ShaneHarvey We're unable to test TLS timeouts in spec tests because there's no infrastructure set up to block TLS handshakes for a specified amount of time. The authentication piece is important because some tests set fail points on saslContinue to test timeouts during the MongoDB handshake, but I thought adding TLS would increase the risk of flaky failures due to the additional set of round trips required without providing any benefit.

@ShaneHarvey
Copy link
Contributor

Ah tls handshake timeouts are interesting but I was moreso thinking about general timeouts when reading from a TLS connection. I know in python the behavior can differ slightly depending on the tls library.

@divjotarora
Copy link
Contributor Author

@ShaneHarvey I added another config file for single-node replica set with both auth and TLS. I've also updated mongodb/specifications#960 to require testing both with and without TLS enabled in commit mongodb/specifications@d668120.

@divjotarora divjotarora requested a review from ShaneHarvey April 15, 2021 18:56
@divjotarora divjotarora merged commit 1d6a678 into mongodb-labs:master Apr 15, 2021
@divjotarora divjotarora deleted the single-node-replset branch April 15, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants