RUST-1111 Support deserializing RawBson from Bson
#331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Dec 2, 2021
| @@ -529,7 +529,7 @@ impl Bson { | |||
| /// This function mainly used for [extended JSON format](https://docs.mongodb.com/manual/reference/mongodb-extended-json/). | |||
| // TODO RUST-426: Investigate either removing this from the serde implementation or unifying | |||
| // with the extended JSON implementation. | |||
| pub(crate) fn into_extended_document(self) -> Document { | |||
| pub(crate) fn into_extended_document(self, rawbson: bool) -> Document { | |||
There was a problem hiding this comment.
rather than implementing various MapAccess structs, the Bson deserializer instead converts things into their "extended document" form and then uses a single MapAccess implementation to walk over the resultant document. The changes here modify this method to create the documents in the form that the raw BSON types expect where necessary.
| /// Hint provided to the deserializer via `deserialize_newtype_struct` as to the type of thing | ||
| /// being deserialized. | ||
| #[derive(Debug, Clone, Copy)] | ||
| enum DeserializerHint { |
There was a problem hiding this comment.
this was originally just used in the raw deserializer, but now that the non-raw deserializer needs to interpret these hints, I've moved it to the top level of the de module.
isabelatkinson
approved these changes
Dec 3, 2021
serde-tests/test.rs
Outdated
| /// - deserializing a `T` from the raw BSON version of `expected_doc` produces `expected_value` | ||
| /// - deserializing a `Document` from the raw BSON version of `expected_doc` produces | ||
| /// `expected_doc` | ||
| /// - serializering `expected_value` to BSON bytes matches the raw BSON bytes of `expected_doc` |
There was a problem hiding this comment.
Suggested change
| /// - serializering `expected_value` to BSON bytes matches the raw BSON bytes of `expected_doc` | |
| /// - serializing `expected_value` to BSON bytes matches the raw BSON bytes of `expected_doc` |
There was a problem hiding this comment.
"serializer-ing" lol, fixed
abr-egn
approved these changes
Dec 3, 2021
patrickfreed
force-pushed
the
RUST-1111/deserialize-owned-raw-bson
branch
from
5e04426 to
0eba63f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1111
This PR adds support to the
Bson-based deserializer (used inbson::from_bsonandbson::from_document) for deserializing the owned raw BSON types, namelyRawBson,RawDocumentBuf, andRawArrayBuf.