RUST-1243 Handle enum keys when deserializing a map from binary #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
approved these changes
Mar 28, 2022
|
Looks like lint needs to be fixed up but besides that LGTM holds (no need for another round of review from me) |
isabelatkinson
approved these changes
Mar 28, 2022
abr-egn
added a commit
to abr-egn/bson-rust
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1243
Prior to this PR, all keys were treated as strings, so the deserialization would fail with "invalid type: string "Key", expected enum Enum". This bug doesn't occur when deserializing from the parsed Bson types because that one uses the main deserializer to parse the key (which knows how to handle enum values) rather than a specialized one.