RUST-1440 bump bson clippy version to 1.63.0 #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
requested review from
a team and
isabelatkinson
and removed request for
a team
|
looks like there are still some clippy errors in CI. I think you've gotta run |
|
Fixed the |
isabelatkinson
approved these changes
Aug 24, 2022
kmahar
approved these changes
Sep 1, 2022
patrickfreed
reviewed
Sep 1, 2022
| @@ -168,7 +169,7 @@ impl crate::DateTime { | |||
| /// | |||
| /// let big = bson::DateTime::from_millis(i64::MAX); | |||
| /// let chrono_big = big.to_chrono(); | |||
| /// assert_eq!(chrono_big, chrono::MAX_DATETIME) | |||
| /// assert_eq!(chrono_big, chrono::DateTime::<chrono::Utc>::MAX_UTC) | |||
There was a problem hiding this comment.
Did chrono drop MAX_DATETIME? Or was this something clippy was complaining about?
There was a problem hiding this comment.
Chrono deprecated MAX_DATETIME, yeah.
src/raw/document_buf.rs
Outdated
| @@ -386,7 +386,7 @@ impl Deref for RawDocumentBuf { | |||
|
|
|||
| impl Borrow<RawDocument> for RawDocumentBuf { | |||
| fn borrow(&self) -> &RawDocument { | |||
| &*self | |||
| &**self | |||
There was a problem hiding this comment.
Why is the extra deref needed here?
There was a problem hiding this comment.
The error clippy made for this:
error: deref on an immutable reference
--> src/raw/document_buf.rs:389:9
|
389 | &*self
| ^^^^^^
|
= note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
help: if you would like to reborrow, try removing `&*`
|
389 | self
|
help: if you would like to deref, try using `&**`
|
389 | &**self
|
I've updated it to call .deref() directly for clarity.
patrickfreed
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.