Skip to content

RUST-1534: implement iter_mut on Document #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2022
Merged

RUST-1534: implement iter_mut on Document #382

merged 3 commits into from
Nov 4, 2022

Conversation

abr-egn
Copy link
Contributor

@abr-egn abr-egn commented Nov 2, 2022

No description provided.

@abr-egn abr-egn requested review from a team and isabelatkinson and removed request for a team November 2, 2022 16:17
@abr-egn abr-egn mentioned this pull request Nov 2, 2022
Merged
isabelatkinson
isabelatkinson approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion but otherwise lgtm!

@abr-egn @isabelatkinson
Update src/document.rs
b124197 
Co-authored-by: Isabel Atkinson <[email protected]>
patrickfreed
patrickfreed approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we file a ticket for this so we remember to mention it in the release notes?

@abr-egn abr-egn changed the title minor: implement iter_mut on Document RUST-1534: implement iter_mut on Document Nov 4, 2022
@abr-egn abr-egn merged commit 8952194 into mongodb:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickfreed patrickfreed patrickfreed approved these changes

@kmahar kmahar kmahar approved these changes

@isabelatkinson isabelatkinson isabelatkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abr-egn @patrickfreed @kmahar @isabelatkinson