RUST-1062 More efficiently serialize array indexes #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
requested review from
a team and
abr-egn
and removed request for
a team
kmahar
reviewed
Nov 14, 2022
src/ser/raw/document_serializer.rs
Outdated
| @@ -225,7 +226,10 @@ impl<'a> serde::Serializer for KeySerializer<'a> { | |||
|
|
|||
| #[inline] | |||
| fn serialize_u64(self, v: u64) -> Result<Self::Ok> { | |||
| Err(Self::invalid_key(v)) | |||
| use std::io::Write; | |||
There was a problem hiding this comment.
should we be concerned at all about users accidentally encountering this and being surprised by the behavior, e.g. if they are working with a HashMap<i64, String> and try to serialize that to BSON?
There was a problem hiding this comment.
Oh good point, I hadn't realized this affected that. From looking at past times this was requested, it seems intentional that we don't convert numbers to strings when serializing (#150), so I've updated this to only use this code path when serializing arrays.
kmahar
approved these changes
Nov 14, 2022
isabelatkinson
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1062
This PR updates the array serialization logic in the raw document serializer to avoid unnecessary heap allocations, resulting in an ~8% improvement in performance in a simple benchmark I'm using.
The solution used here is a bit different than the originally proposed one to just push bytes directly onto the buffer, but it was necessary in order to preserve the expected byte order (pushing them would result in a backwards string). As a result, the performance improvements were not as significant as originally envisioned unfortunately.