RUST-2003 Binary vector subtype support #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
force-pushed
the
vector-subtype
branch
from
2481b9b to
a8b5aa4
Compare
isabelatkinson
commented
Jan 23, 2025
| /// | ||
| /// Padding must be within 0-7 inclusive. Padding must be 0 or unspecified if the provided | ||
| /// vector is empty. | ||
| pub fn new(vector: Vec<u8>, padding: impl Into<Option<u8>>) -> Result<Self> { |
There was a problem hiding this comment.
the spec requires this type to be valid upon construction, hence the opaque type and result-returning new method
| /// let binary = Binary::from(vector); | ||
| /// ``` | ||
| /// | ||
| /// `Vector` serializes to and deserializes from a `Binary`. |
There was a problem hiding this comment.
I don't think there's much value in treating this type as anything other than a convenience wrapper around Binary when it comes to serde, but we can revisit if a use case arises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2003